Update HookEnabled interface with resourceinterpreter #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
release-note-none
karmada-bot
added
the
size/M
|
Wait for #1253 |
XiShanYongYe-Chang
force-pushed
the
update-hookenabled-interface
branch
from
042baf4 to
6d54156
Compare
karmada-bot
added
the
do-not-merge/contains-merge-commits
XiShanYongYe-Chang
force-pushed
the
update-hookenabled-interface
branch
from
6d54156 to
5632b0b
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
Signed-off-by: changzhen <[email protected]>
XiShanYongYe-Chang
force-pushed
the
update-hookenabled-interface
branch
from
5632b0b to
fc7616e
Compare
|
/cc @RainbowMango |
|
Let's invite @iawia002 to take a look. |
|
/cc @iawia002 Please help take a look :) |
|
Nice work! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: changzhen [email protected]
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
HookEnabledinterface with resource interpreter feature can be refactored to need objectGVK instead of object parameter.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: